Skip to content

feat: Add generic TOML updater#1833

Merged
chingor13 merged 2 commits intogoogleapis:mainfrom
phated:phated/generic-toml-updater
Jan 26, 2023
Merged

feat: Add generic TOML updater#1833
chingor13 merged 2 commits intogoogleapis:mainfrom
phated:phated/generic-toml-updater

Conversation

@phated
Copy link
Copy Markdown
Contributor

@phated phated commented Jan 26, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1832 🦕

@phated phated requested review from a team January 26, 2023 21:13
@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Jan 26, 2023
@phated
Copy link
Copy Markdown
Contributor Author

phated commented Jan 26, 2023

Also, I just want to say that the toml-edit.ts code is totally awesome and I really wish it were a separate dependency that other projects could consume. ❤️

@phated phated force-pushed the phated/generic-toml-updater branch from ea46bb6 to b066a66 Compare January 26, 2023 21:29
@phated phated force-pushed the phated/generic-toml-updater branch from b066a66 to f43d68c Compare January 26, 2023 21:46
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chingor13 chingor13 merged commit 2768a4c into googleapis:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generic TOML updater

2 participants