Skip to content

feat!: Support Node 18+ #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielbankhead merged 9 commits into from
Oct 4, 2024
Merged

feat!: Support Node 18+ #2011

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9199b18
feat!: Support Node 18+
d-goog Sep 18, 2024
d22a13e
chore: Additional Node 18 upgrades
d-goog Sep 18, 2024
b5f5ccb
Merge branch 'master' of github.com:googleapis/synthtool into prepare…
d-goog Sep 23, 2024
431d757
chore: don't change test fixtures
d-goog Sep 23, 2024
10d361b
feat: Move kokoro directories to 18
d-goog Sep 23, 2024
0828740
Merge branch 'master' into prepare-node-18
d-goog Sep 24, 2024
d68a92a
Merge branch 'master' into prepare-node-18
d-goog Oct 3, 2024
0407f07
chore: Update checkout and setup-node to v4
d-goog Oct 3, 2024
e9ff844
Merge branch 'prepare-node-18' of github.com:googleapis/synthtool int…
d-goog Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions synthtool/gcp/templates/node_library/.github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [{{metadata['engine'] | int}}, {{metadata['engine'] | int+2}}, {{metadata['engine'] | int+4}}, {{metadata['engine'] | int+6}}]
node: [{{metadata['engine'] | int}}, {{metadata['engine'] | int+2}}, {{metadata['engine'] | int+4}}}]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand All @@ -32,7 +32,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 14
node-version: 18
- run: npm install --engine-strict
- run: npm test
env:
Expand All @@ -43,7 +43,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 14
node-version: 18
- run: npm install
- run: npm run lint
docs:
Expand All @@ -52,7 +52,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 14
node-version: 18
- run: npm install
- run: npm run docs
- uses: JustinBeckwith/linkinator-action@v1
Expand Down
2 changes: 1 addition & 1 deletion synthtool/gcp/templates/node_library/.kokoro/common.cfg
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...rary/.kokoro/continuous/node14/common.cfg → ...rary/.kokoro/continuous/node18/common.cfg
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 ...ibrary/.kokoro/continuous/node14/lint.cfg → ...ibrary/.kokoro/continuous/node18/lint.cfg
View file
Open in desktop
File renamed without changes.
0 ...kokoro/continuous/node14/samples-test.cfg → ...kokoro/continuous/node18/samples-test.cfg
View file
Open in desktop
File renamed without changes.
0 ....kokoro/continuous/node14/system-test.cfg → ....kokoro/continuous/node18/system-test.cfg
View file
Open in desktop
File renamed without changes.
0 ...ibrary/.kokoro/continuous/node14/test.cfg → ...ibrary/.kokoro/continuous/node18/test.cfg
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...brary/.kokoro/presubmit/node14/common.cfg → ...brary/.kokoro/presubmit/node18/common.cfg
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 ....kokoro/presubmit/node14/samples-test.cfg → ....kokoro/presubmit/node18/samples-test.cfg
View file
Open in desktop
File renamed without changes.
0 .../.kokoro/presubmit/node14/system-test.cfg → .../.kokoro/presubmit/node18/system-test.cfg
View file
Open in desktop
File renamed without changes.
0 ...library/.kokoro/presubmit/node14/test.cfg → ...library/.kokoro/presubmit/node18/test.cfg
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion synthtool/gcp/templates/node_library/.kokoro/release/docs-devsite.cfg
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion synthtool/gcp/templates/node_library/.kokoro/release/docs.cfg
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion synthtool/gcp/templates/node_library/.kokoro/release/docs.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion synthtool/gcp/templates/node_library/.kokoro/release/publish.cfg
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion synthtool/gcp/templates/node_library/.kokoro/samples-test.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion synthtool/gcp/templates/node_library/.kokoro/system-test.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion synthtool/gcp/templates/node_library/.kokoro/test.bat
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion synthtool/gcp/templates/node_library/.kokoro/test.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion synthtool/gcp/templates/node_library/.kokoro/trampoline_v2.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

⚡