Skip to content

build: switch to patched Windows image with Node 12#378

Merged
bcoe merged 4 commits intomasterfrom
new-windows-image
Jan 22, 2020
Merged

build: switch to patched Windows image with Node 12#378
bcoe merged 4 commits intomasterfrom
new-windows-image

Conversation

@bcoe
Copy link
Copy Markdown

@bcoe bcoe commented Jan 21, 2020

While applying patches to Windows image, I also fixed up some path issues.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2020
@bcoe bcoe requested a review from JustinBeckwith January 21, 2020 00:50
@bcoe bcoe added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 21, 2020
@bcoe
Copy link
Copy Markdown
Author

bcoe commented Jan 21, 2020

I'd like to create the manual PR for this before landing.

Comment thread synthtool/gcp/templates/node_library/.kokoro/test.bat
@bcoe bcoe force-pushed the new-windows-image branch from 7799d50 to a15b885 Compare January 21, 2020 21:02
@bcoe bcoe removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 22, 2020
@bcoe bcoe merged commit 2d53d93 into master Jan 22, 2020
@bcoe bcoe deleted the new-windows-image branch January 22, 2020 05:10
@sofisl sofisl mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants