chore(java): default samples/snippets pom should not use libraries-bom#694
Merged
chingor13 merged 2 commits intogoogleapis:masterfrom Jul 24, 2020
Merged
chore(java): default samples/snippets pom should not use libraries-bom#694chingor13 merged 2 commits intogoogleapis:masterfrom
chingor13 merged 2 commits intogoogleapis:masterfrom
Conversation
We are now only adding clients to libraries-bom once the client is 1.0.0. Since this template is created at repository creation time, we don't want to include the libraries-bom installation method here.
google-cla
Bot
added
the
cla: yes
SurferJeffAtGoogle
approved these changes
Jul 24, 2020
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
chingor13
added
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are now only adding clients to libraries-bom once the client is
1.0.0. Since this template is created at repository creation time, we
don't want to include the libraries-bom installation method here.
Note: that this template is only added the first time - if a samples/snippets/pom.xml file exists, we leave the current file.