Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid CI failures during template upgrades (or just Python bumps if consumers do so) the venv created using older Python version must not be restored from cache.
Adding a Python version key seems easier than trying to document the fact consumers need to remember manually going into their Actions looking into the right Caches and deleting all of them (which also needs certain permissions for the repo, so can't be e.g. ensured from just a PR doing the upgrade etc.)
Doing some extra/fragile shenanigans to be more lax and only key to major.minor could be viable, but this achieves precise version for the sake of simplicity, given older Python versions don't really get frequent updates (compared to the useful cache lifetime):
This also updates actions versions to prepare for upcoming runner deprecations.