Fixed capture-preview naming behaviour#3
Merged
msmeissn merged 1 commit intogphoto:masterfrom Sep 20, 2015
Merged
Conversation
Launching gphoto2 as follows:
// And invoke capture-preview, saves the picture using "--filename" argument
gphoto2: {/tmp/pics} /> capture-preview
Saving file as pic.jpg
The prefix "thumb_" should be added in front of the "--filename" specified.
Without "--filename" argument:
cagphoto2: {/tmp/pics} /> capture-preview
Saving file as thumb_capture_preview.jpg
With "--filename" argument:
gphoto2: {/tmp/pics} /> capture-preview
Saving file as thumb_pic.jpg
Contributor
Author
|
You are right, but i think the mistake might be over here: https://github.com/gphoto/libgphoto2/blob/master/libgphoto2/gphoto2-file.c#L919 The patch is only applying GP_FILE_TYPE_PREVIEW for pics taken with "capture-preview". I think then "thumb_" naming convetion should be fixed on libgphoto2... right? |
msmeissn
added a commit
that referenced
this pull request
Sep 20, 2015
Fixed capture-preview naming behaviour
Contributor
|
I will see if I can do it like this:
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launching gphoto2 as follows:
// And invoke capture-preview, saves the picture using "--filename" argument
gphoto2: {/tmp/pics} /> capture-preview
Saving file as pic.jpg
The prefix "thumb_" should be added in front of the "--filename" specified.
Without "--filename" argument:
cagphoto2: {/tmp/pics} /> capture-preview
Saving file as thumb_capture_preview.jpg
With "--filename" argument:
gphoto2: {/tmp/pics} /> capture-preview
Saving file as thumb_pic.jpg