Skip to content

GAN Gradio Guide: Adjustments to iframe heights#1042

Merged
aliabd merged 1 commit into
gradio-app:mainfrom
NimaBoscarino:guides/gan-crypto-fix
Apr 20, 2022
Merged

GAN Gradio Guide: Adjustments to iframe heights#1042
aliabd merged 1 commit into
gradio-app:mainfrom
NimaBoscarino:guides/gan-crypto-fix

Conversation

@NimaBoscarino
Copy link
Copy Markdown
Contributor

Description

As a follow-up to #1000, this PR adjusts the heights of the iframes so that they are an appropriate size (not too big, and no scroll bars).

I haven't been able to deploy the front-end locally to verify this (my laptop is having some issues!) but I manually altered the iframe heights in the HTML for https://gradio.app/create_your_own_friends_with_a_gan/ to pick appropriate heights.

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@aliabd
Copy link
Copy Markdown
Contributor

aliabd commented Apr 20, 2022

LGTM

In case it helps, there are the steps to launch the website:

To launch run sh scripts/build_frontend.sh and then sh scripts/launch_website.sh, website will be running on localhost:8000
To have the website live reload just run npm run start on a separate terminal from scripts/launch_website.sh.

@aliabd aliabd merged commit 20847c5 into gradio-app:main Apr 20, 2022
@NimaBoscarino NimaBoscarino deleted the guides/gan-crypto-fix branch April 20, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants