Form layout#1054
Merged
Merged
Conversation
pngwn
commented
Apr 21, 2022
pngwn
commented
Apr 21, 2022
gary149
reviewed
Apr 21, 2022
pngwn
commented
Apr 21, 2022
Member
|
Wowow the screenshots (especially the second one) look so nice! @pngwn what do you think about a dedicated
Beyond the scope of this PR, but we can create an issue around it. |
gary149
approved these changes
Apr 21, 2022
Co-authored-by: Victor Muštar <victor.mustar@gmail.com>
Member
Author
|
@abidlabs I think it would be good to have a conversation around the narrative for interface + blocks and where those boundaries like. We could say to users that for layouts like this then they should move to blocks. That said I think your proposed 'section' component would be really nice. It could take a title, aribtrary (and optional) markdown and a list of components. It could be collapsible, configurable via a flag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements form groupings when there is more than 1 adjacent form. Part of #1041.
Run
demo/fake_gan_complexto see this in action in a complex flow of components (with multiple foprms groups of different sizes).Run
demo/kitchen_sinkto see all forms together.@gary149 Few implementation notes here. I added a new class to the
componentslayer of tailwind to apply the new spacing. We had to switch to margins instead ofgapbecause you can't switch offgapfor certain elements. The lobotomised owl selector is pretty standard for child component spacing though and gives us the flexibility we need. Let me know what you think.We do have some styling in the global css and some in the components themselves but since those styles are applied to components directly we still remain in complete control, so I think it should be ok.
Screenshots