Skip to content

Running, testing, and fixing demos#1060

Merged
abidlabs merged 2 commits into
mainfrom
demo-fixes2
Apr 22, 2022
Merged

Running, testing, and fixing demos#1060
abidlabs merged 2 commits into
mainfrom
demo-fixes2

Conversation

@abidlabs
Copy link
Copy Markdown
Member

@abidlabs abidlabs commented Apr 21, 2022

Fixes include:

  • For examples, using paths relative to the demo file, so that the demo can be run from anywhere
  • Fixing parameter names (default_value instead of default)
  • Making demos test more parameters/features (e.g. placeholder)

@abidlabs abidlabs marked this pull request as draft April 21, 2022 15:57
@abidlabs abidlabs marked this pull request as ready for review April 21, 2022 16:21
@abidlabs abidlabs requested review from omerXfaruq and pngwn April 21, 2022 16:21
Copy link
Copy Markdown
Contributor

@omerXfaruq omerXfaruq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this usage a lot!
os.path.join(os.path.dirname(__file__),"sax.wav"),

Would you like to use this standard for the file usages within tests? That would enable running individual test functions or classes from IDE or different locations other the repo folder.

@abidlabs
Copy link
Copy Markdown
Member Author

I like this usage a lot!
os.path.join(os.path.dirname(file),"sax.wav"),

Would you like to use this standard for the file usages within tests? That would enable running individual test functions or classes from IDE or different locations other the repo folder.

Good idea -- can do that in a future PR

@abidlabs abidlabs merged commit 4c1c735 into main Apr 22, 2022
@abidlabs abidlabs deleted the demo-fixes2 branch April 22, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants