fixed favicon issue#1064
Merged
Merged
Conversation
omerXfaruq
approved these changes
Apr 22, 2022
|
|
||
| @app.get("/favicon.ico") | ||
| async def favicon(): | ||
| return FileResponse(app.blocks.favicon_path) |
Contributor
There was a problem hiding this comment.
I am not sure about this but weren't we doing some checks to file paths to not access to different paths within user's computer?
like os.some_function
Member
Author
There was a problem hiding this comment.
Yes, I thought about this as well. In this case, we don't have to worry about that because the favicon route only returns a fixed filepath that is specified by the demo creator. Where this can become a security concern is if a demo user can request a file at an arbitrary path (like in the /file/ route)
Member
Author
|
Going to add a default favicon, as suggested by @pngwn, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had dropped support for favicons at some point. This implements it again. Closes: #1036
Sample code to test: