Blocks rendering fix#1102
Merged
Merged
Conversation
omerXfaruq
reviewed
Apr 27, 2022
Contributor
omerXfaruq
left a comment
omerXfaruq
left a comment
There was a problem hiding this comment.
LGTM, would be better if @aliabid94 takes a look as well.
Contributor
|
Discussed with @abidlabs earlier, but instead of unrender method, get_component_shortcuts should just create Components with render=False in cunstructor. Should remove the need for unrender. |
Member
Author
|
I discussed some more with @aliabid94 and we will actually keep import gradio as gr
blocks = gr.Blocks()
with blocks:
gr.Interface(
fn=lambda x: x,
inputs=gr.Image(),
outputs=gr.Image())
blocks.launch() |
omerXfaruq
reviewed
Apr 28, 2022
| @@ -3100,7 +3099,7 @@ def __init__( | |||
| label (str): component name | |||
Contributor
There was a problem hiding this comment.
need to update docstring with the label's removal
| label: Optional[str] = None, | ||
| css: Optional[Dict] = None, | ||
| **kwargs, | ||
| ): |
Contributor
There was a problem hiding this comment.
not related to this PR but, Dataset has no docstring, let's add one?
| label: Optional[str] = None, | ||
| css: Optional[Dict] = None, | ||
| **kwargs, | ||
| ): |
Contributor
There was a problem hiding this comment.
not related to this PR but, Interpretation has no docstring, let's add one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Blocks so that it can be used inside other blocks as plug-and-play components (Closes: [Blocks] Support Blocks components as Plug and Use components #960)
Added a demo to illustrate usage:
demo\blocks_plug\run.pyAlso adds
articleparameter back intoInterface(Closes: Article parameter not rendered on Interface beta #1093)