Small fixes: queue default fix, ffmpeg installation message#1159
Merged
Conversation
abidlabs
changed the title
aliabid94
reviewed
May 4, 2022
| except FileNotFoundError as e: | ||
| error_message = str(e) | ||
| if "ffprobe" in error_message: | ||
| print("Please install `ffmpeg` in your system to use Audio.") |
Contributor
There was a problem hiding this comment.
Maybe clarify ffmpeg is needed to use non-WAV file formats, not the Audio component in general.
Contributor
|
LGTM, small message change comment |
abidlabs
commented
May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable_queuecorrectly for Blocks so that on Spaces,enable_queueisTrueby defaultCloses: #976. Closes: #1101. Closes #1116