Skip to content

enable flex grow for gr-box#1165

Merged
pngwn merged 1 commit into
gradio-app:mainfrom
radames:gr-box-grow
May 5, 2022
Merged

enable flex grow for gr-box#1165
pngwn merged 1 commit into
gradio-app:mainfrom
radames:gr-box-grow

Conversation

@radames
Copy link
Copy Markdown
Contributor

@radames radames commented May 5, 2022

Description

For individual elements on a row, use flex-1 so it grows and shrinks as needed

Before:
image

After:

image

@radames radames requested review from gary149 and pngwn May 5, 2022 17:27
Copy link
Copy Markdown
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. @gary149 am i missing anything obvious here or is this good to merge?

@radames
Copy link
Copy Markdown
Contributor Author

radames commented May 5, 2022

thanks @pngwn I've added @gary149, but we came to that conclusion together in call this morning!

@abidlabs
Copy link
Copy Markdown
Member

abidlabs commented May 5, 2022

Looks great to me too. I think this would close #1029 too.

@pngwn pngwn merged commit a9610a4 into gradio-app:main May 5, 2022
@pngwn
Copy link
Copy Markdown
Member

pngwn commented May 5, 2022

I'll check #1029 and close that.

@pngwn
Copy link
Copy Markdown
Member

pngwn commented May 5, 2022

Thanks @radames !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants