A few small fixes#1171
Merged
Merged
Conversation
aliabid94
approved these changes
May 6, 2022
| Slider, | ||
| StatusTracker, | ||
| Textbox, | ||
| TimeSeries, |
Member
Author
There was a problem hiding this comment.
Different spelling (or casing actually)
Member
Author
There was a problem hiding this comment.
TimeSeries vs Timeseries
Member
Author
There was a problem hiding this comment.
That is what you're referring to, right?
|
|
||
| self.interface_type = self.InterfaceTypes.STANDARD | ||
| if inputs is None and outputs is None: | ||
| if (inputs is None or inputs == []) and (outputs is None or outputs == []): |
Contributor
There was a problem hiding this comment.
since you call super.init() first, you could just check if self.inputs == [].
Member
Author
There was a problem hiding this comment.
Where in Blocks() do I assign self.inputs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few small things I noticed as I was building demos / writing the
Blocksguidegr.DataFrameis now equivalent togr.Dataframe) -- Closes: Rename (or accept both names) Dataframe to DataFrame #1110inputs=Noneoroutputs=Noneto an event trigger