962 dataframe#1186
Merged
Merged
Conversation
Member
|
Wow took me a while to review all of the fixes and new features. Great work, especially love the drag-and-drop csv! There are a couple of minor issues that I noticed -- for example, dataframe examples don't adjust the number of rows in the dataframe UI when clicked, which can cause problems if the number of rows in the example < the number of rows in the dataframe UI. But these are pretty minor things we can address post 3.0 launch, overall LGTM. Pushed a few tweaks to make everything work, and will go ahead and merge so that we can release a new version. |
abidlabs
approved these changes
May 9, 2022
This was referenced Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the refreshed dataframe and captures most the changes that have been discussed.
Short version: i changed the dataframe. Try it by running
demo/blocks_outputs, I added a few dataframes there.API
col_widthhas been removed (Dataframe Improvements #962)row_countcan now take aintor a tuple of (int, 'fixed' | 'dynamic') (Dataframe Improvements #962)col_countcan now take aintor a tuple of (int, 'fixed' | 'dynamic') (Dataframe Improvements #962)col_countand the lengthheadersare the same. We could probably do more validation but I think this is enough to start with.UX
col_count=(n, 'fixed')then that is how many columns will show up. Data is trimmed or blanks are filled in as needed.col_count=(n, 'fixed')then that is how many rows will show up. Data is trimmed or blanks are filled in as needed.col_count=(n, 'fixed')the "New Column" button is hidden and the action prevented.row_count=(n, 'fixed')the "New Row" button is hidden and the action is prevents.Bugs
The only thing that hasn't been done is removing rows + cols. There is an open issue for that which we will get to later, it will need some UX work but I don't think it needs to block 3.0
Closes #753. Closes #868. Closes #1065. Closes #945. Closes #962. Closes #745.
(need to double check #745 is fixed by this)