Conversation
|
let's also use this as an opportunity to improve/speed up the way we pass the |
Yes, totally agree @julien-c |
|
Context (for Spaces) : We currently check if the As @julien-c mentioned, in order to speed-up Space page loads, @pngwn what do you think of this ? |
|
@cbensimon Are those query params set depending on what is set in the hub? Would light/ dark ever be set if the hub doesn't have a toggle? I think those three values would give us what we need on the gradio side to keep things in sync with the surrouding context. Edit: I see the toggle is in settings. In that case, I think this makes sense to me and would allow us to keep everything nicely synced with the hub. |
|
I can add this logic to the PR here, falling back to system for non-space gradio apps. There will also be some work required on the hub, could that be ready for Gradio 3.0 release on wednesday? |
|
on the hub side i think it's just going to be a super super small PR. @cbensimon will link it to here when it's ready |
The The old (current) |
It's not a problem if it's not ready on hub-side for Wednesday as we're going to be backward compatible by still taking |
|
|
Tested with a bunch of blocks and interface demos. Really good stuff guys! |
This PR adds support for dark mode:
Please note:
currentColorbut it might require inline svgs.ui/packages/theme/src/colors.ts. It's not done by now.Closes #741