Skip to content

Sharing fix for assets#1208

Merged
abidlabs merged 9 commits into
mainfrom
share_fix
May 11, 2022
Merged

Sharing fix for assets#1208
abidlabs merged 9 commits into
mainfrom
share_fix

Conversation

@aliabid94
Copy link
Copy Markdown
Contributor

@aliabid94 aliabid94 commented May 10, 2022

When uploading to pypi, will create a second template html that links to the CDN for assets directly called share.html. When share=True, this file is used as the template.

Closes: #1028

@abidlabs
Copy link
Copy Markdown
Member

Have you tested this with a pypi release or would you like me to?

@abidlabs
Copy link
Copy Markdown
Member

@abidlabs
Copy link
Copy Markdown
Member

I don't know why the tests are timing out on CircleCI, they work fine locally. Any ideas @aliabid94?

@abidlabs
Copy link
Copy Markdown
Member

Works! To test, try gradio==2.9b48

@abidlabs abidlabs closed this May 11, 2022
@abidlabs abidlabs reopened this May 11, 2022
@abidlabs abidlabs merged commit c50a2b0 into main May 11, 2022
@abidlabs abidlabs deleted the share_fix branch May 11, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Footer appears twice (once above the interface) when share=True

2 participants