Skip to content

Issue #1160: Model 3D component not destroyed correctly#1219

Merged
abidlabs merged 6 commits into
mainfrom
dawood/model3d-fix
May 15, 2022
Merged

Issue #1160: Model 3D component not destroyed correctly#1219
abidlabs merged 6 commits into
mainfrom
dawood/model3d-fix

Conversation

@dawoodkhan82
Copy link
Copy Markdown
Collaborator

@dawoodkhan82 dawoodkhan82 commented May 11, 2022

Description

Please include:

  • relevant motivation
  • a summary of the change
  • which issue is fixed.
  • any additional dependencies that are required for this change.

Closes: #1160

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dawoodkhan82
Copy link
Copy Markdown
Collaborator Author

@abidlabs Can you test this with Radames demo?

@abidlabs
Copy link
Copy Markdown
Member

I was able to actually reproduce this issue with our demo/model3d/run.py example, and the problem is not fixed by this PR.

To reproduce the problem:

  • Navigate to the /model3d/ directory
  • Make sure to delete the gradio_cached_examples folder if it exists
  • Run python run.py
  • When the interface loads, click on one of the examples
  • Without pressing clear, click on one of the other examples

For me, the second example does not load. I'm perpetually stuck in this state:

image

@abidlabs
Copy link
Copy Markdown
Member

Any update on this @dawoodkhan82?

@abidlabs
Copy link
Copy Markdown
Member

Cool, this fixed it for me! @radames it would be great if you can confirm that it fixes it for you too!

@abidlabs abidlabs merged commit e26609e into main May 15, 2022
@abidlabs abidlabs deleted the dawood/model3d-fix branch May 15, 2022 07:51
@shankch
Copy link
Copy Markdown

shankch commented Aug 6, 2022

Hello @abidlabs, I am facing the same problem now. When I run the first time , the 3d model output works, but when I submit again, the output shows "ERROR". My app takes text as input and generates 3d model as output. Please fix this.

@dawoodkhan82
Copy link
Copy Markdown
Collaborator Author

dawoodkhan82 commented Aug 6, 2022

Hello @abidlabs, I am facing the same problem now. When I run the first time , the 3d model output works, but when I submit again, the output shows "ERROR". My app takes text as input and generates 3d model as output. Please fix this.

@shankch This should be fixed by #1939. Which was released in version 3.1.4b. Can you give that a try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model 3D component not destroyed correctly (cached examples)

3 participants