update-shortcut-syntax#1234
Merged
Merged
Conversation
- fix&update gr.component - create a demo introducing shortcuts within Blocks
- tweaks
- tweaks
- fix formatting
radames
reviewed
May 12, 2022
Contributor
radames
left a comment
radames
left a comment
There was a problem hiding this comment.
It looks cool to me! thanks for the new demo, I guess it now makes more sense.
pngwn
reviewed
May 12, 2022
Comment on lines
+15
to
+21
| with gr.Row(): | ||
| with gr.Column(): | ||
| text1 = gr.component("textarea") | ||
| with gr.Column(): | ||
| text2 = gr.TextArea() | ||
| with gr.Column(): | ||
| text3 = gr.templates.TextArea() |
Member
There was a problem hiding this comment.
Would having these components at the top level achieve the same layout?
- tweaks - fix tests
- tweaks - fix tests
- tweaks - fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gr.component()'s functionality was changed and lost its main purpose, it was returning classes instead of objects, return that functionality back.