Layout bugs#1246
Merged
Merged
Conversation
Member
Author
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay.
Closes #1233. Closes #1237. Closes #1238.
visible=True|Falsewasn't working as we had switched out styling to a new system, reimplemented.Row(mobile_collapse) so that users can disable the mobile collumn collapsing. This is important because we use flex for everything and need to switch this off for some small elements, like buttons, that we want to appear side by side even on mobile (such as the 'Clear' and 'Submit' buttons in interface)Button(full_width) as buttons will not fill the width of their container typically (which is good but sometimes it is needed for certain layouts).I had to rethink how we were handling layouts as it was causing a number of issue. I think we were adding more and more classes to workaround issues that were arising and it was becoming difficult to manage all of the different case. I decided to go backa nd clean up a little by removing some of the probl;ematic classes and relying on things being full width (which will cause them to flex correctly most of the time), rather than tweaking the flex properties of the individual children.
I've tested this pretty extensively across screensizes here are some screengrabs showing current behaviour:
Screen.Recording.2022-05-13.at.14.02.50.mov
Screen.Recording.2022-05-13.at.15.10.22.mov