Conversation
pngwn
commented
May 13, 2022
aliabid94
reviewed
May 14, 2022
aliabid94
reviewed
May 14, 2022
aliabid94
reviewed
May 14, 2022
aliabid94
approved these changes
May 14, 2022
Contributor
aliabid94
left a comment
There was a problem hiding this comment.
Small suggestions, otherwise looks great!
Member
|
Love it! |
Member
|
Will merge it in so that I can start working on all of the merge conflicts that are bound to happen soon |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Popped this up for everyone to take a look. Feeel free to propose alternative solutions, names, etc.
This was the demo i was able to create with the addition of these APIs.
The code looks like this: