Skip to content

maybe fix auth in iframes #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pngwn merged 8 commits into from
May 16, 2022
Merged

maybe fix auth in iframes #1261

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
151bf8d
maybe fix auth in iframes
pngwn May 15, 2022
d3a9fda
remove comment
pngwn May 15, 2022
5e50be0
Merge branch 'main' into login
aliabid94 May 15, 2022
ff8e120
Update gradio/templates/frontend/index.html
pngwn May 15, 2022
c61b85f
Merge branch 'main' into login
pngwn May 15, 2022
6a69f56
Merge branch 'login' of github.com:gradio-app/gradio into login
pngwn May 15, 2022
75d3fde
fix gitignore?
pngwn May 15, 2022
894698b
Merge branch 'main' of github.com:gradio-app/gradio into login
abidlabs May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gradio/templates/frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"
>
<head>
<base target="_blank" />
<!-- <base target="_blank" /> -->
Comment thread
pngwn marked this conversation as resolved.
Outdated
Comment thread
pngwn marked this conversation as resolved.
Outdated
<meta charset="utf-8" />
<meta
name="viewport"
Expand Down Expand Up @@ -59,8 +59,8 @@
rel="stylesheet"
/>
<script src="https://cdnjs.cloudflare.com/ajax/libs/iframe-resizer/4.3.1/iframeResizer.contentWindow.min.js"></script>
<script type="module" crossorigin src="./assets/index.11df9c88.js"></script>
<link rel="stylesheet" href="./assets/index.4b0ec74e.css">
<script type="module" crossorigin src="./assets/index.2696258f.js"></script>
<link rel="stylesheet" href="./assets/index.bf810f69.css">
</head>

<body
Expand Down
1 change: 0 additions & 1 deletion ui/packages/app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"
>
<head>
<base target="_blank" />
<meta charset="utf-8" />
<meta
name="viewport"
Expand Down
8 changes: 8 additions & 0 deletions ui/packages/app/src/Blocks.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,14 @@

async function handle_mount() {
await tick();

Copy link
Copy Markdown
Contributor

@aliabid94 aliabid94 May 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we affecting all links on the page?

Copy link
Copy Markdown
Member Author

@pngwn pngwn May 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we want to open them all in a new tab (including any links that are generated via markdown, which is why we need to do it this way), this was previously being done with the base element but that also affects form actions which we don't want because of the login form in iframes.

var a = document.getElementsByTagName("a");

for (var i = 0; i < a.length; i++) {
const target = a[i].getAttribute("target");
if (target !== "_blank") a[i].setAttribute("target", "_blank");
}

dependencies.forEach(
(
{ targets, trigger, inputs, outputs, queue, backend_fn, frontend_fn },
Expand Down
1 change: 1 addition & 0 deletions ui/packages/app/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ window.launchGradio = (config: Config, element_query: string) => {
target: target,
props: config
});
window.__gradio_loader__.$set({ status: "complete" });
} else {
handle_darkmode(target);

Expand Down
⚡