Skip to content

Static forms#1264

Merged
pngwn merged 2 commits into
mainfrom
static-forms
May 15, 2022
Merged

Static forms#1264
pngwn merged 2 commits into
mainfrom
static-forms

Conversation

@pngwn
Copy link
Copy Markdown
Member

@pngwn pngwn commented May 15, 2022 •
edited
Loading

Alternative to #1262.

  • If a component has is not an input or ouput it will be dynamic, for a better dev workflow.
  • If a component is used as an output but never an input it will be static (I know that non-intercative form inputs can be a little confusing but being able to interact and nothing ever happen is worse imo, we may be able to improve the UX in the future)

So broadly:

  • Nothing - interactive
  • Input - interactive
  • Input + output - interactive
  • output - static
  • explicitinteractive=bool are always respected

@pngwn pngwn requested review from abidlabs and aliabid94 May 15, 2022 17:21
@pngwn pngwn mentioned this pull request May 15, 2022
Closed
@aliabid94
Copy link
Copy Markdown
Contributor

aliabid94 commented May 15, 2022

LGTM!

@pngwn pngwn merged commit ed074f9 into main May 15, 2022
@pngwn pngwn deleted the static-forms branch May 15, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abidlabs abidlabs Awaiting requested review from abidlabs

1 more reviewer

@aliabid94 aliabid94 aliabid94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pngwn @aliabid94
⚡