Skip to content

Miscellaneous formatting improvements to website#1754

Merged
abidlabs merged 5 commits into
mainfrom
aliabd/website-formatting
Jul 19, 2022
Merged

Miscellaneous formatting improvements to website#1754
abidlabs merged 5 commits into
mainfrom
aliabd/website-formatting

Conversation

@aliabd
Copy link
Copy Markdown
Contributor

@aliabd aliabd commented Jul 11, 2022

Small formatting fixes to docs and guides.

Fixes #1717

@aliabd
Copy link
Copy Markdown
Contributor Author

aliabd commented Jul 11, 2022

@abidlabs can you document the visible and variant params in BlockContext? Just fill the content where I put the TODO

Copy link
Copy Markdown
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @aliabd ! Thanks for making these improvements.

Only thing is that color_map in Chatbot is still undocumented. Looks like we deprecated that parameter in favor of Chatbot.style. Maybe we just add color_map to the docstring saying it's deprecated? Not blocking merge though

@abidlabs
Copy link
Copy Markdown
Member

abidlabs commented Jul 11, 2022

Only thing is that color_map in Chatbot is still undocumented. Looks like we deprecated that parameter in favor of Chatbot.style. Maybe we just add color_map to the docstring saying it's deprecated? Not blocking merge though

Seems unnecessary to document the color_map parameter if it's deprecated I think? Let's instead make sure we document the style() methods for all of the components, as mentioned in #1757

@abidlabs
Copy link
Copy Markdown
Member

@abidlabs can you document the visible and variant params in BlockContext? Just fill the content where I put the TODO

Done @aliabd!

@aliabid94
Copy link
Copy Markdown
Contributor

LGTM

@abidlabs abidlabs merged commit a44f8f7 into main Jul 19, 2022
@abidlabs abidlabs deleted the aliabd/website-formatting branch July 19, 2022 04:33
@freddyaboulton freddyaboulton mentioned this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Miscellaneous formatting improvements to website after PR 1578

4 participants