Mock out requests in TestRequest unit tests

[freddyaboulton]

Description

Requests unit tests were failing because https://reqres.in/api/users is unavailable. See this PR for an example: #1785

This PR mocks out the calls to that api to make the tests pass and not have to rely on external services

Checklist:

• I have performed a self-review of my own code
• My code follows the style guidelines of this project
• I have commented my code in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[freddyaboulton]

Lol looks like the service is back up again. I still think it's worthwhile to remove dependencies on external services from unit tests so I'll keep this PR open to hear what people think!

[abidlabs]

Let's mock this request to "headers.jsontest.com" as well?

[abidlabs]

Thanks for fixing this @freddyaboulton! Agreed that this is definitely the better approach. I noticed a couple of things:

• There are some Requests that are not mocked. See the tests in lines 263, 323, 347. Let's mock these as well?
• We currently define the same MagicMock across various functions. Would be good to apply the mock at a class level to avoid repeating code: https://docs.python.org/3/library/unittest.mock-examples.html#applying-the-same-patch-to-every-test-method

[abidlabs]

Thanks for fixing this @freddyaboulton! Agreed that this is definitely the better approach. I noticed a couple of things:

• There are some Requests that are not mocked. See the tests in lines 263, 323, 347. Let's mock these as well?
• We currently define the same MagicMock across various functions. Would be good to apply the mock at a class level to avoid repeating code: https://docs.python.org/3/library/unittest.mock-examples.html#applying-the-same-patch-to-every-test-method

[abidlabs]

Thanks for fixing this @freddyaboulton! Agreed that this is definitely the better approach. I noticed a couple of things:

• There are some Requests that are not mocked. See the tests in lines 263, 323, 347. Let's mock these as well?
• We currently define the same MagicMock across various functions. Would be good to apply the mock at a class level to avoid repeating code: https://docs.python.org/3/library/unittest.mock-examples.html#applying-the-same-patch-to-every-test-method

[freddyaboulton]

Changing the url so that it's clear that we're mocking

[freddyaboulton]

Thank you for the review @abidlabs ! Completely agree with your comments - I mocked out the remaining requests and applied the mock to the class. This is good for another review now!

[abidlabs]

Very clean, thanks for addressing the suggestions @freddyaboulton!

[omerXfaruq]

Sounds good! actually there is a similar library for this which I like, it mocks the request call and you don't mock your code at all. I would suggest we use it, but @freddyaboulton's approach works as well!

The library is aioresponses and there is a pytest plugin .

[freddyaboulton]

@farukozderim Thank you for bringing up that library. I'll file an issue to switch to that to get this merged in. I think there's lots of room to improve how we write tests (#1784)