Skip to content

Add requirements.txt and test_files to source dist#1817

Merged
freddyaboulton merged 1 commit into
mainfrom
1812-add-missing-files-to-source-dist
Jul 18, 2022
Merged

Add requirements.txt and test_files to source dist#1817
freddyaboulton merged 1 commit into
mainfrom
1812-add-missing-files-to-source-dist

Conversation

@freddyaboulton
Copy link
Copy Markdown
Collaborator

@freddyaboulton freddyaboulton commented Jul 18, 2022

Description

Fixes #1812

How to test

  1. Clone this branch
  2. python setup.py sdist
  3. In a fresh env, pip install dist/gradio-3.0.26.tar.gz should install gradio + all dependencies
  4. Unpack the source distribution. test/test_files and test/requirements.txt should be included.
    image

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Comment thread MANIFEST.in
recursive-include test/test_files *
include gradio/version.txt
include requirements.txt
include test/requirements.txt No newline at end of file
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbsds can you let me know if you need the test requirements?

Copy link
Copy Markdown
Contributor

@pbsds pbsds Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not personally, but their inclusion is at best a kilobyte

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@freddyaboulton freddyaboulton marked this pull request as ready for review July 18, 2022 15:52
@freddyaboulton freddyaboulton merged commit 175bba2 into main Jul 18, 2022
@freddyaboulton freddyaboulton deleted the 1812-add-missing-files-to-source-dist branch July 18, 2022 16:03
@ofek ofek mentioned this pull request Sep 10, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

requirements.txt not bundled on pypi

3 participants