-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add python-3.7 tests #1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add python-3.7 tests #1818
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
0163023
Add python-3.7 tests
freddyaboulton 9b7e5fd
Format components
freddyaboulton 7ee0c5c
Use latest images
freddyaboulton 91464f1
Use python instead of python3
freddyaboulton 11c5fcd
Force reset cache
freddyaboulton 802fd5e
Reset cache
freddyaboulton 66e854a
Use Ipython 7 for python 3.7 support
freddyaboulton 3a47d91
Install chrome
freddyaboulton 177d144
Add two text files
freddyaboulton 835c4d2
Reset cache
freddyaboulton 271e54c
Use Literal from typing extensions
freddyaboulton c522b5c
Update cache key
freddyaboulton 3365df8
Linting
freddyaboulton 717b228
Fix requests tests
freddyaboulton 433b309
Exit if running from wrong python version
freddyaboulton 6b5c79d
Use one requirements file
freddyaboulton a8ece24
Fix comment
freddyaboulton 6931920
Fix comment
freddyaboulton e96f2ea
Use python 3.7.13
freddyaboulton 11d1ca6
empty commit
freddyaboulton 21416b5
Delete chrome driver to see if it works
freddyaboulton e50bd84
Test no chrome with new cache
freddyaboulton ba4f655
Remove chrome driver install entirely
freddyaboulton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,17 +12,19 @@ | |
| import os | ||
| import pathlib | ||
| import shutil | ||
| import sys | ||
| import tempfile | ||
| import warnings | ||
| from copy import deepcopy | ||
| from types import ModuleType | ||
| from typing import Any, Callable, Dict, List, Optional, Tuple | ||
| from typing import TYPE_CHECKING, Any, Callable, Dict, List, Optional, Tuple | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is for #1807 |
||
|
|
||
| if sys.version_info[0] == 3 and sys.version_info[1] >= 8: | ||
| if TYPE_CHECKING: | ||
|
abidlabs marked this conversation as resolved.
|
||
| from typing import TypedDict | ||
| else: | ||
| from typing_extensions import TypedDict | ||
|
|
||
| class DataframeData(TypedDict): | ||
| headers: List[str] | ||
| data: List[List[str | int | bool]] | ||
|
|
||
|
|
||
| import matplotlib.figure | ||
| import numpy as np | ||
|
|
@@ -2400,11 +2402,6 @@ def style( | |
| ) | ||
|
|
||
|
|
||
| class DataframeData(TypedDict): | ||
| headers: List[str] | ||
| data: List[List[str | int | bool]] | ||
|
|
||
|
|
||
| @document() | ||
| class Dataframe(Changeable, IOComponent): | ||
| """ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,5 +18,4 @@ uvicorn | |
| Jinja2 | ||
| fsspec | ||
| httpx | ||
| pydantic | ||
| typing-extensions | ||
| pydantic | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,4 +17,5 @@ black | |
| isort | ||
| flake8 | ||
| httpx | ||
| pydantic | ||
| pydantic | ||
| respx | ||
|
abidlabs marked this conversation as resolved.
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how you install the chrome driver on the new images
Docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need chrome and chrome driver?