Fix streaming issues#1828
Merged
Merged
Conversation
Member
Collaborator
|
Thanks @aliabid94 ! Confirmed this fixes the audio/image streaming example. The only thing is that I noticed a very faint flicker in the audio component during flicker (you can kind of see it at second 7 in this gif) but I think that's ok Not sure about #1323 |
Member
|
Yup also tested this with the examples from our real time ASR guide: from transformers import pipeline
import gradio as gr
import time
p = pipeline("automatic-speech-recognition")
def transcribe(audio, state=""):
time.sleep(2)
text = p(audio)["text"]
state += text + " "
return state, state
gr.Interface(
fn=transcribe,
inputs=[
gr.Audio(source="microphone", type="filepath", streaming=True),
"state"
],
outputs=[
"textbox",
"state"
],
live=True).launch()and the examples work great! I think we can fix the flicker & clean up any other issues we fine in a future PR, but for the sake of releasing 3.1, let's go ahead and merge this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hide status loading animation on stream, fix echo in stream on last audio chunk.
Check demo/stream_audio for example.
Still not 100% if audio streaming is being done the correct way (basically stopping and starting the MediaRecorder at 500ms intervals) but seems to work.