Skip to content

Wandb guide #1898

Merged
abidlabs merged 54 commits into
gradio-app:mainfrom
AK391:main
Aug 23, 2022
Merged

Wandb guide #1898
abidlabs merged 54 commits into
gradio-app:mainfrom
AK391:main

Conversation

@AK391
Copy link
Copy Markdown
Contributor

@AK391 AK391 commented Jul 26, 2022

Opening a WIP PR that fixes: #1759

Guide on how to integrate with Weights and Biases

@abidlabs abidlabs marked this pull request as draft July 28, 2022 18:51
@abidlabs
Copy link
Copy Markdown
Member

abidlabs commented Jul 28, 2022

Moving to draft status for now -- let us know when you want a review @AK391!

@AK391
Copy link
Copy Markdown
Contributor Author

AK391 commented Aug 1, 2022

@abidlabs should be ready for review now, also will be sending this to the wandb team in slack to go over and to see if they want to use the wandb organization https://huggingface.co/wandb on HF to adding gradio demos made through following this guide

@abidlabs abidlabs marked this pull request as ready for review August 1, 2022 23:26
@abidlabs abidlabs changed the title (WIP) wandb guide Wandb guide Aug 1, 2022
Comment thread guides/4)integrating_other_frameworks/Gradio_and_Wandb_Integration.md Outdated
Comment thread guides/4)integrating_other_frameworks/Gradio_and_Wandb_Integration.md Outdated
@abidlabs
Copy link
Copy Markdown
Member

abidlabs commented Aug 1, 2022

Hey @AK391, I moved the Guide to the proper location in the repo, so that it would be visible when building locally. However, the Guide's formatting looks all messed up to me:

http://localhost:8000/Gradio_and_Wandb_Integration/

image

Something's off about the Markdown syntax. Is the Guide looking fine for you locally? Let me know if you need any help setting up the website locally

AK391 and others added 7 commits August 2, 2022 20:47
Comment thread guides/4)integrating_other_frameworks/Gradio_and_Wandb_Integration.md Outdated
@abidlabs
Copy link
Copy Markdown
Member

abidlabs commented Aug 5, 2022

Thanks @AK391 this looks much better.

I'm still seeing some weird things, though. For example, all of this "@markdown" in the code. Is this supposed to be here?

image

And some code not being formatted as code, like here:

image

I can make a pass through the Guide tomorrow and clean up these formatting issues.

Would you be able put together a "final" colab notebook with all of the jojogan, gradio, and wandb code in one place that we could link to?

@AK391
Copy link
Copy Markdown
Contributor Author

AK391 commented Aug 5, 2022

@abidlabs thanks for checking @markdown is actually from the original colab notebook https://colab.research.google.com/github/mchong6/JoJoGAN/blob/main/stylize.ipynb from the jojogan repo, it renders panels like this to interact with rather than running the code cell but I will remove it from the guide as its confusing
Screen Shot 2022-08-05 at 1 16 24 PM

@abidlabs
Copy link
Copy Markdown
Member

abidlabs commented Aug 5, 2022

Sounds good, we're pretty close I think -- just let me know when you want me to review again.

@AK391
Copy link
Copy Markdown
Contributor Author

AK391 commented Aug 11, 2022

@abidlabs final colab is ready https://colab.research.google.com/drive/1Xq7YLsE3CNqGjcmfj5hiwGXCnYY3anrm?usp=sharing, one issue when using blocks and then integrate, works fine but when using interface and integrate I get this error

AttributeError                            Traceback (most recent call last)
<ipython-input-14-2371ac6ca7c4> in <module>()
----> 1 demo.integrate(wandb=wandb)

AttributeError: 'tuple' object has no attribute 'integrate'

@AK391
Copy link
Copy Markdown
Contributor Author

AK391 commented Aug 11, 2022

@abidlabs thanks, issue should be resolved now, updated colab and the code block in the guide

@AK391
Copy link
Copy Markdown
Contributor Author

AK391 commented Aug 20, 2022

@abidlabs following up on this, should be ready for review

@abidlabs
Copy link
Copy Markdown
Member

Sounds good, will take a look today!

@abidlabs
Copy link
Copy Markdown
Member

Thanks for making all of the edits, @AK391, looks good to me :)

I made some tweaks to shorten things up and I think maybe the code can be shortened even more, but it's a good guide for now!

I'll go ahead and merge it in after the CI runs

@abidlabs abidlabs merged commit e63ffb3 into gradio-app:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write a guide on how to integrate with Weights and Biases

2 participants