Fix infinite requests when doing tab item select#2070
Merged
Conversation
Contributor
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2070-all-demos |
freddyaboulton
commented
Aug 23, 2022
| <button | ||
| class="px-4 pb-2 pt-1.5 border-transparent text-gray-400 hover:text-gray-700 -mb-[2px] border-2 border-b-0" | ||
| on:click={() => (selected = t.id)} | ||
| on:click={() => change_tab(t.id)} |
Collaborator
Author
There was a problem hiding this comment.
TBH not sure how the old code was causing the original problem but it seems to be fixed now 😬
Member
|
Can confirm that the demos work, but it would be good to get some confirmation from the front end team: @aliabid94 @dawoodkhan82 @pngwn? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2069
To test, run the reproducer and switch tabs successfuly.
blocks_plugalso works as expected.Don't think this breaks anything but would be good to get the opinion of a front-end expert.
Checklist: