Skip to content

Updated our analytics on creation of Blocks/Interface#2082

Merged
abidlabs merged 7 commits into
mainfrom
initiated-analytics
Aug 25, 2022
Merged

Updated our analytics on creation of Blocks/Interface#2082
abidlabs merged 7 commits into
mainfrom
initiated-analytics

Conversation

@abidlabs
Copy link
Copy Markdown
Member

Three quick changes to our analytics on creation of Blocks/Interface:

  • We actually fire the analytics when Blocks are created (previously, it was only when Interface was created)
  • We record whether it was a Blocks or Interface that was created (using "mode")
  • We also record which Gradio version they are running

I've also updated the gradio-api-server running to accept these analytics. We should keep in mind that we'll see an artificial bump in the "initiation" analytics as a result of this. For retrospective analysis, we should stick to launch analytics, which correctly record whenever Blocks are launched

@abidlabs abidlabs requested a review from dawoodkhan82 August 25, 2022 17:27
@github-actions
Copy link
Copy Markdown
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2082-all-demos

@dawoodkhan82
Copy link
Copy Markdown
Collaborator

@abidlabs the tests with analytics_enabled are mocked right?

Copy link
Copy Markdown
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @abidlabs ! I think we're mocking the requests so we should be good to go.

That being said, I don't think we're setting analytics_enabled to False in the all_demos demo that's being deployed to spaces so we should do that! I can do that too, up to you!

@abidlabs
Copy link
Copy Markdown
Member Author

Thanks for the review, guys! Will update all_demos, fix the tests, and then merge in.

@abidlabs abidlabs merged commit 4a1321c into main Aug 25, 2022
@abidlabs abidlabs deleted the initiated-analytics branch August 25, 2022 20:23
@ghost
Copy link
Copy Markdown

ghost commented Nov 7, 2022

Hey! @abidlabs, if i enable analytics where do I go to see the analytics for my space (if that's even possible?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants