Updated our analytics on creation of Blocks/Interface#2082
Merged
Conversation
Contributor
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2082-all-demos |
Collaborator
|
@abidlabs the tests with analytics_enabled are mocked right? |
freddyaboulton
approved these changes
Aug 25, 2022
Collaborator
freddyaboulton
left a comment
There was a problem hiding this comment.
Looks good to me @abidlabs ! I think we're mocking the requests so we should be good to go.
That being said, I don't think we're setting analytics_enabled to False in the all_demos demo that's being deployed to spaces so we should do that! I can do that too, up to you!
dawoodkhan82
approved these changes
Aug 25, 2022
Member
Author
|
Thanks for the review, guys! Will update |
|
Hey! @abidlabs, if i enable analytics where do I go to see the analytics for my space (if that's even possible?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three quick changes to our analytics on creation of Blocks/Interface:
I've also updated the
gradio-api-serverrunning to accept these analytics. We should keep in mind that we'll see an artificial bump in the "initiation" analytics as a result of this. For retrospective analysis, we should stick to launch analytics, which correctly record whenever Blocks are launched