Skip to content

Allow frontend method execution on Block.load event#2108

Merged
abidlabs merged 5 commits into
gradio-app:mainfrom
codedealer:allow-js-on-load
Aug 29, 2022
Merged

Allow frontend method execution on Block.load event#2108
abidlabs merged 5 commits into
gradio-app:mainfrom
codedealer:allow-js-on-load

Conversation

@codedealer
Copy link
Copy Markdown
Contributor

Description

Please include:
Adds _js as an optional parameter to the load event similar to other events

Closes: #2105

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@abidlabs
Copy link
Copy Markdown
Member

Thank you for the PR @codedealer! LGTM

@codedealer codedealer requested a review from abidlabs August 29, 2022 11:06
@codedealer
Copy link
Copy Markdown
Contributor Author

@abidlabs Hey, I changed the tests to account for the changed js argument (optional value from bool to none). Let me know if I need to do anything else.

@abidlabs
Copy link
Copy Markdown
Member

Thank you so much @codedealer for the contribution. Looks ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow frontend method execution on Block.load event

2 participants