Skip to content

feat(samples table/gallery): Crop thumbs to square#2109

Merged
abidlabs merged 1 commit into
mainfrom
feat/square-crop-samples
Aug 31, 2022
Merged

feat(samples table/gallery): Crop thumbs to square#2109
abidlabs merged 1 commit into
mainfrom
feat/square-crop-samples

Conversation

@ronvoluted
Copy link
Copy Markdown
Contributor

Crops image/video thumbnails in Examples section so they look neater. Slack thread on pros/cons

Before

image

image

After

image

image

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • New and existing unit tests pass locally with my changes

@ronvoluted ronvoluted requested a review from gary149 August 29, 2022 06:02
@github-actions
Copy link
Copy Markdown
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2109-all-demos

@abidlabs
Copy link
Copy Markdown
Member

Thanks @ronvoluted! @pngwn or @aliabid94 if you wanna take a look, then we can merge it in!

Copy link
Copy Markdown
Contributor

@aliabid94 aliabid94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abidlabs abidlabs merged commit 78d94cf into main Aug 31, 2022
@abidlabs abidlabs deleted the feat/square-crop-samples branch August 31, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants