use correct MIME type for js-script file#2200
Merged
Merged
Conversation
Member
|
Hi @daspartho this seems reasonable. Were you able to reproduce the original issue and can you confirm that this fixes it? |
Contributor
Author
|
I reproduced the original issue and was able to resolve it with this. |
Member
|
Great, I haven't been able to test it since I can't reproduce the original issues, but the code changes look reasonable to me. Let me format it and then merge it in! |
Contributor
Author
|
Thank you for your valuable input :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1203
This makes the server use the proper MIME type for the js-script file.
I made the changes as suggested in the issue. @abidlabs could you please review the changes i made?