Skip to content

Fix Web Tracker Script#2308

Merged
aliabd merged 3 commits into
mainfrom
aliabd/fix-web-tracker
Sep 23, 2022
Merged

Fix Web Tracker Script#2308
aliabd merged 3 commits into
mainfrom
aliabd/fix-web-tracker

Conversation

@aliabd
Copy link
Copy Markdown
Contributor

@aliabd aliabd commented Sep 20, 2022

Fixes the issue with the web tracker script, which is spamming slack with success messages despite not actually reloading the website.

Problem was that I miswrote the if condition. This should work fine now and I've already started testing it on the gradio machine so we can see until this gets merged.

@aliabd aliabd requested a review from aliabid94 September 20, 2022 21:13
@github-actions
Copy link
Copy Markdown
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2308-all-demos

Copy link
Copy Markdown
Contributor

@aliabid94 aliabid94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aliabd aliabd merged commit 8ca7f9c into main Sep 23, 2022
@aliabd aliabd deleted the aliabd/fix-web-tracker branch September 23, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants