Supports gr.update() in example caching#2309
Merged
Merged
Conversation
abidlabs
commented
Sep 20, 2022
Contributor
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2309-all-demos |
abidlabs
commented
Sep 21, 2022
freddyaboulton
approved these changes
Sep 21, 2022
Collaborator
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
This looks good to me @abidlabs ! Thanks for the fix.
Member
Author
|
Thank you so much @freddyaboulton for the comprehensive review. I've patched all of the holes now and this should be all set to merge after the tests pass |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we couldn't handle
gr.update()in flagging or example caching, as described in #2305. This PR fixes that.Fixes: #2305
I'm still writing some tests but ready to be reviewed