Skip to content

Fix: Dataframe column headers are reset when you add a new column#2318

Merged
dawoodkhan82 merged 2 commits into
mainfrom
dawood/headers-issue
Sep 23, 2022
Merged

Fix: Dataframe column headers are reset when you add a new column#2318
dawoodkhan82 merged 2 commits into
mainfrom
dawood/headers-issue

Conversation

@dawoodkhan82
Copy link
Copy Markdown
Collaborator

@dawoodkhan82 dawoodkhan82 commented Sep 21, 2022

Description

Saves new and edited header names when user presses "Enter"/"Escape"/"Tab" or clicks outside dataframe.

Screen.Recording.2022-09-21.at.10.23.05.AM.mov

Please include:

  • relevant motivation
  • a summary of the change
  • which issue is fixed.
  • any additional dependencies that are required for this change.

Closes: #2155

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions
Copy link
Copy Markdown
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2318-all-demos

Copy link
Copy Markdown
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great @dawoodkhan82 !

Copy link
Copy Markdown
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dawoodkhan82 dawoodkhan82 merged commit 3a4a826 into main Sep 23, 2022
@dawoodkhan82 dawoodkhan82 deleted the dawood/headers-issue branch September 23, 2022 17:50
@dawoodkhan82 dawoodkhan82 self-assigned this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataframe column headers are reset when you add a new column

3 participants