-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Adds ability to provide a gr.update() dictionary even if postprocess=False
#2385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
13c8357
docs
abidlabs 5840af8
Merge branch 'prepostex' into updict
abidlabs a0b2183
Merge branch 'prepostex' into updict
abidlabs bc44bcc
fixes
abidlabs 9070306
added docs, fixed test
abidlabs 9bb6264
changelog
abidlabs a5c1a7c
fix suggestoins
abidlabs 0697359
formatting
abidlabs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to your PR but why do we not set the value of a state to be an update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm good point. I suppose that if the update includes a
valuekey, we should assign thevalueto the state.I think this check was introduced because if a function returns values in a component-dictionary format (e.g.
{textbox: "hi"}), we create placeholder updates for the rest of the components, and those placeholder components are a singleton dictionary:{"__type__"="generic_update"}. And we wouldn't want to assign this dictionary itself to the state.Let me make a fix and add a test!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine if we keep it for now too - don't mean to slow down this PR. I was just curious hehe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok actually
gr.State()doesn't have anupdate()method at the moment, so passing in a dictionary of updates forgr.State()is not supported. There's no strong reason to addupdate()when a function can just return the value itself, so I'll leave this out for now.