Load Event Trigger#2456
Conversation
| * Fix bug where new typeable slider doesn't respect the minimum and maximum values [@dawoodkhan82](https://github.com/dawoodkhan82) in [PR 2380](https://github.com/gradio-app/gradio/pull/2380) | ||
| * Add guide on creating a map demo using the `gr.Plot()` component [@dawoodkhan82](https://github.com/dawoodkhan82) in [PR 2402](https://github.com/gradio-app/gradio/pull/2402) | ||
| * Add blur event for `Textbox` and `Number` components [@dawoodkhan82](https://github.com/dawoodkhan82) in [PR 2448](https://github.com/gradio-app/gradio/pull/2448) | ||
|
|
There was a problem hiding this comment.
Moving these to the right section
There was a problem hiding this comment.
@freddyaboulton Seems like changelog check is failing. Is it because I'm moving these to the right section?
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2456-all-demos |
|
Very cool @dawoodkhan82! Tested and works great for all four of the components. I do have one suggestion, which is to rename the event from
I also think that every component should have a version of this event trigger. For example, |
|
I think this is a good addition until we change the API but I'm not sure this really fixes #2419 because An app author would need to track when both events are triggering in order to distinguish them, but I don't think that is reliable unless we send a session ID with each request and I'm not sure if we document the order in which events are fired or maintain that as a part of the API, so the required user code to make this work would be even more complex. So this fixes #2419 in one direction but not in the other. |
…radio into dawood/upload-event
abidlabs
left a comment
There was a problem hiding this comment.
Left a few minor comments, but otherwise looks good!
Description
Add event trigger for when a user uploads to video, audio, file, and image components.
Screen.Recording.2022-10-13.at.5.16.16.PM.mov
Please include:
Closes: #2419
Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.