fix #2536#2538
Conversation
|
I don't know how svelte works is it compiling now? can I get the compiled code from ci? |
| <img | ||
| alt="" | ||
| class="h-full w-full overflow-hidden object-contain" | ||
| src={typeof image === "string" ? image : image.data} | ||
| /> |
There was a problem hiding this comment.
We don't need to duplicate this block and wrap it in an if, we can just fall back to an empty string:
<img
alt={caption || ""}
class="h-full w-full overflow-hidden object-contain"
src={typeof image === "string" ? image : image.data}
/>|
Awesome. Thanks so much @camenduru. Not sure why this is skipping the deploy to spaces workflow but I'll take a look at that. |
|
We just need to add a changelog entry for this. Do you want to take care of that or would you like me to do it? This would considered a bug fix. |
|
That workflow doesn't run on forks because secrets aren't copied to forks. Need to host that workflow on a separate repo in order to get it to run on forks I think. Something we should do |
|
@pngwn please add changelog I don't know how? and can I get compiled files from ci? |
|
Not sure what you mean about getting compiled files from CI but you can get everything locally form this branch. The templates are in |
|
You are right, thanks for your help. |
|
This PR is still good, no need to close. |
|
I'll take of the changelog + merge soon. |
thanks @pngwn
Closes: #2536