Skip to content

fix #2536#2538

Merged
pngwn merged 5 commits into
gradio-app:mainfrom
camenduru:patch-1
Oct 27, 2022
Merged

fix #2536#2538
pngwn merged 5 commits into
gradio-app:mainfrom
camenduru:patch-1

Conversation

@camenduru
Copy link
Copy Markdown
Contributor

thanks @pngwn

Closes: #2536

thanks @pngwn
@camenduru
Copy link
Copy Markdown
Contributor Author

I don't know how svelte works is it compiling now? can I get the compiled code from ci?

@camenduru camenduru closed this Oct 26, 2022
@camenduru camenduru reopened this Oct 26, 2022
Comment on lines -192 to -196
<img
alt=""
class="h-full w-full overflow-hidden object-contain"
src={typeof image === "string" ? image : image.data}
/>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to duplicate this block and wrap it in an if, we can just fall back to an empty string:

<img
  alt={caption || ""}
  class="h-full w-full overflow-hidden object-contain"
  src={typeof image === "string" ? image : image.data}
/>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks ♥

@pngwn
Copy link
Copy Markdown
Member

pngwn commented Oct 26, 2022

Awesome. Thanks so much @camenduru.

Not sure why this is skipping the deploy to spaces workflow but I'll take a look at that.

@pngwn
Copy link
Copy Markdown
Member

pngwn commented Oct 26, 2022

We just need to add a changelog entry for this. Do you want to take care of that or would you like me to do it?

This would considered a bug fix.

@freddyaboulton
Copy link
Copy Markdown
Collaborator

That workflow doesn't run on forks because secrets aren't copied to forks. Need to host that workflow on a separate repo in order to get it to run on forks I think. Something we should do

@camenduru
Copy link
Copy Markdown
Contributor Author

@pngwn please add changelog I don't know how? and can I get compiled files from ci?

@pngwn
Copy link
Copy Markdown
Member

pngwn commented Oct 26, 2022

Not sure what you mean about getting compiled files from CI but you can get everything locally form this branch. The templates are in gradio/templates after you have build the frontend by following the instructions in the readme file in ui/README.md

@camenduru
Copy link
Copy Markdown
Contributor Author

You are right, thanks for your help.

@camenduru camenduru closed this Oct 26, 2022
@pngwn
Copy link
Copy Markdown
Member

pngwn commented Oct 26, 2022

This PR is still good, no need to close.

@pngwn pngwn reopened this Oct 26, 2022
@pngwn
Copy link
Copy Markdown
Member

pngwn commented Oct 26, 2022

I'll take of the changelog + merge soon.

@pngwn pngwn merged commit cf7d445 into gradio-app:main Oct 27, 2022
@camenduru camenduru deleted the patch-1 branch October 27, 2022 18:16
@freddyaboulton freddyaboulton self-assigned this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please add an option -> pass text to gallery image alt attribute

3 participants