Properly dequeue cancelled events when multiple apps are rendered#2540
Merged
freddyaboulton merged 3 commits intoOct 26, 2022
Merged
Conversation
Contributor
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2540-all-demos |
freddyaboulton
force-pushed
the
properly-dequeu-cancelled-events-multiple-blocks
branch
from
302dfa9 to
ca58b48
Compare
Member
|
Good catch @freddyaboulton! |
abidlabs
approved these changes
Oct 26, 2022
Member
abidlabs
left a comment
abidlabs
left a comment
There was a problem hiding this comment.
Tested, very cool @freddyaboulton
Collaborator
Author
|
Thank you for the review @abidlabs ! Will merge once CI finishes |
freddyaboulton
deleted the
properly-dequeu-cancelled-events-multiple-blocks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #2530
Cancelled events were not properly dequeued because the background task was not cancelled. You can see that here:
Not dequeued (main)
Dequeued (this pr)
The fix is to also update the fn indices in the cancel functions. I thought about giving the dependencies an id that's invariant to the number of dependencies in the demo but that would be a bigger change that doesn't seem worth it when adding an if statement to
renderfixes the issue.Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.