Skip to content

Allow None in as_example for files#2588

Merged
freddyaboulton merged 5 commits into
mainfrom
2549-allow-none-file-examples
Nov 1, 2022
Merged

Allow None in as_example for files#2588
freddyaboulton merged 5 commits into
mainfrom
2549-allow-none-file-examples

Conversation

@freddyaboulton
Copy link
Copy Markdown
Collaborator

@freddyaboulton freddyaboulton commented Nov 1, 2022

Description

Fixes #2549

To test, you can run the repro from the original bug ticket. There are unit tests as well.

Checklist:

  • I have performed a self-review of my own code
  • I have added a short summary of my change to the CHANGELOG.md
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

A note about the CHANGELOG

Hello 👋 and thank you for contributing to Gradio!

All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.

Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by [@myusername](link-to-your-github-profile) in [PR 11111](https://github.com/gradio-app/gradio/pull/11111)".

If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2022

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2588-all-demos

@freddyaboulton freddyaboulton marked this pull request as ready for review November 1, 2022 17:44
@freddyaboulton freddyaboulton requested review from abidlabs, aliabd, aliabid94, dawoodkhan82, omerXfaruq and pngwn and removed request for omerXfaruq November 1, 2022 17:44
@abidlabs
Copy link
Copy Markdown
Member

abidlabs commented Nov 1, 2022

Nice fix @freddyaboulton! LGTM

@freddyaboulton
Copy link
Copy Markdown
Collaborator Author

Thanks for the review @abidlabs !

@freddyaboulton freddyaboulton merged commit f0d1cdf into main Nov 1, 2022
@freddyaboulton freddyaboulton deleted the 2549-allow-none-file-examples branch November 1, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot load examples with missing file paths

2 participants