Use read_sql in database guide#2604
Merged
Merged
Conversation
Member
|
Nice! |
Contributor
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2604-all-demos |
freddyaboulton
force-pushed
the
use-from-sql-in-guide
branch
from
7983238 to
71907ce
Compare
freddyaboulton
requested review from
abidlabs,
aliabd,
aliabid94,
dawoodkhan82 and
pngwn
abidlabs
reviewed
Nov 4, 2022
| This will make our app more secure by avoiding storing sensitive information as plain text in our application files. | ||
|
|
||
| ```python | ||
| DB_USER = os.getenv("DB_USER") |
Member
There was a problem hiding this comment.
I would add the import statements so that the code is more complete
Suggested change
| DB_USER = os.getenv("DB_USER") | |
| import os | |
| import pandas as pd | |
| DB_USER = os.getenv("DB_USER") |
Member
There was a problem hiding this comment.
And below, would import gradio as gr
Member
|
This is great thanks for the simplification @freddyaboulton! Notice that when I tried out the code on a fresh install, I also needed to have |
abidlabs
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify the "connect to database" guide by using pd.read_sql.
Also moves the associated space to the gradio org.
Closes: # (issue)
Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.