Allow auth with using queue#2611
Conversation
websockets with version <=9.1 with raise TypeError: WebSocketCommonProtocol.__init__() got an unexpected keyword argument 'logger'
fix wrong position in changlog from the last pr gradio-app#2428 also
|
Very cool, thanks @GLGDLY! Testing now |
|
Works great, thanks a lot @GLGDLY! |
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
Thank you for the very nice PR @GLGDLY ! Left some comments and questions. Once those are addressed these should be good to merge 😄
| async def startup_events(): | ||
| app.blocks.startup_events() | ||
| return True | ||
| if not app.startup_events_triggered: |
There was a problem hiding this comment.
How come we need this change?
There was a problem hiding this comment.
the comments are removed here, it is changed to allow the initialization to run the queue background coros
| if msg["msg"] == "process_completed": | ||
| assert msg["success"] | ||
| assert msg["output"]["data"] == ["Hello 123!"] | ||
| assert _loop.time() > _time |
There was a problem hiding this comment.
This is not passing on our CI. I don't think we need to check the time. I think it would be sufficient to test that the output is correct. Might make sense to rewrite this loop so that the "name" is different for each event in the queue.
There was a problem hiding this comment.
"name" is different for each event in the queue is added now, time is checked as I think we need to ensure the queue is actually working
| sleep_time = 5 | ||
|
|
||
| async def say_hello(name): | ||
| await asyncio.sleep(sleep_time) |
There was a problem hiding this comment.
I don't think we need to sleep for so long. The test takes quite a while to run right now.
There was a problem hiding this comment.
it is 1 sec and 3 times now
|
Thank you @aliabid94 @freddyaboulton , I will take a look at the problems later today🙏🏻 |
|
Thank you @GLGDLY ! |
ok thanks! |
3 participants
Description
Allow auth with using queue, initiated by #2215 , which if queue is on by default, authentication then cannot be used by default. A partial fix to #293 as well.
Also fix wrong position in changlog from the last pr #2428
Checklist: