Pin fastapi test version to 0.87.0#2647
Conversation
|
@freddyaboulton should we update the tests themselves instead to use the latest version of fastapi? Don't have a strong opinion, but looks like there is a handy bump tool |
|
@abidlabs Either works but not both. Either we do |
|
My preference would be to upgrade if it's not a lot of work, so that we are up-to-date in our version of fastapi. But I agree with you, either could work for now |
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2647-all-demos |
|
@abidlabs Upgraded to 0.87 instead! |
|
Cool LGTM thanks @freddyaboulton! |
Description
Looks like the new fastapi version (0.87.0, released yesterday) has a hard pin on starlette 0.21.0 which introduces breaking changes to the testclient.
fastapi/fastapi#5471
Rather than putting a pin in the version in
requirements.txt(which would force all users to upgrade fastapi/starlette versions), I am only putting a pin in the version of fastapi installed for the unit tests.Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.