Skip to content

Embeds: support <gradio-app host="julien-c-coqui.hf.space"></gradio-app>#2692

Merged
abidlabs merged 7 commits into
mainfrom
fix-embeds
Nov 22, 2022
Merged

Embeds: support <gradio-app host="julien-c-coqui.hf.space"></gradio-app>#2692
abidlabs merged 7 commits into
mainfrom
fix-embeds

Conversation

@julien-c
Copy link
Copy Markdown
Contributor

to support the 'embed this Space' modal that will be shipped soon by internal PR

@julien-c julien-c requested a review from pngwn November 21, 2022 22:24
@github-actions
Copy link
Copy Markdown
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2692-all-demos

@julien-c julien-c requested a review from abidlabs November 21, 2022 22:33
@abidlabs
Copy link
Copy Markdown
Member

abidlabs commented Nov 22, 2022

Thanks @julien-c. I think some of these iframes can be replaced with web components altogether -- let me update them and then we can merge this in.

Edit: never mind, the web component approach requires us to embed the gradio js files which can be tricky in guides that have multiple embedded demos. Let's stick with iframes here

Copy link
Copy Markdown
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these updates @julien-c!

@abidlabs abidlabs merged commit c99a323 into main Nov 22, 2022
@abidlabs abidlabs deleted the fix-embeds branch November 22, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants