Conversation
Contributor
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2695-all-demos |
aliabid94
approved these changes
Dec 20, 2022
Member
Author
|
Thanks for the review @aliabid94! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we didn't implement
allow_flaggingset to "auto" when we re-implementedInterfaceto be constructed fromBlocks. This restores that functionality.Test with a script like this:
Fixes: #2603
After discussion with @aliabid94, modified the functionality of "auto" to only log the input data. This simplifies the implementation considerably because there's no easy way to flag the data "once the prediction has completed running", and we think approach is reasonable for this relatively rare use case. Updated the documentation to reflect this functionality