enhancement: record audio and video from webcam simultaneously#2721
Conversation
|
@MandarGogate @abidlabs |
|
We should probably make this an option to ensure the author has choice and that users aren't bombarded with permission requests when they run apps. Many models don't need or can't use both audio and video inputs. |
|
Agreed with @pngwn‘s suggestion — ideally we have a Boolean parameter e.g. “include_audio” which can be True by default and applies to the webcam scenario but also to the regular Video component. In other words, if it is False then the audio from an uploaded Video would be removed as well |
|
I have added |
pngwn
left a comment
There was a problem hiding this comment.
Looks good to me. Left a few suggestions for the wording of the change log and docstring.
Co-authored-by: pngwn <hello@pngwn.io>
Co-authored-by: pngwn <hello@pngwn.io>
|
Is defaulting to |
Good point, let's test with a few Spaces that currently take in a webcam video. I believe @nateraw has built some... |
|
Sorry for the late response @jeeanribeiro. I tested this out and it turns out setting cc @pngwn @aliabid94 |
|
@abidlabs I have updated the default behaviour of include_audio and merged latest changes from |
|
Tested and works great. Couple of tests need to be fixed but I can go ahead and do that -- thanks for this addition to the gradio library @jeeanribeiro! |
Description
From @MandarGogate issue:
Changes:
Closes: #2704
Checklist: