Fixed a type bug where the validation was "binary"#2727
Merged
Conversation
In line 2113 the type was validated as either file or binary:
```python
valid_types = ["file", "binary"]
if type not in valid_types:
raise ValueError(
f"Invalid value for parameter `type`: {type}. Please choose from one of: {valid_types}"
)
```
However line 2183 preprocess single file wanted either "file" or "bytes"
```python
elif self.type == "bytes":
```
I have arbitrarily picked binary as the one to match, but now they are both consistent.
Member
|
Thank you for catching this @CoffeeVampir3. I'll add a test, and then credit you in the changelog and then go ahead and merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix for the type component, without this fix it is impossible to pick "binary" or "bytes" files because one is thrown out by the validator and one is thrown out by the type check in the process single file loop.
In line 2113 the type was validated as either file or binary:
However line 2183 preprocess single file wanted either "file" or "bytes"
I have picked binary as the one to match because the documentation currently reflects the choice of "file" or "binary". No changes should be needed to existing docs.
Please see the following errors for reference:
Process single file value error:
Initialization error
Description
Please include:
Closes: # (issue)
Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.