Skip to content

Enable requests timout for version_check#2729

Merged
abidlabs merged 4 commits into
gradio-app:mainfrom
yujiehecs:version-check-patch
Nov 28, 2022
Merged

Enable requests timout for version_check#2729
abidlabs merged 4 commits into
gradio-app:mainfrom
yujiehecs:version-check-patch

Conversation

@yujiehecs
Copy link
Copy Markdown
Contributor

@yujiehecs yujiehecs commented Nov 27, 2022

Description

As described in the issue #2726: No timeout for version_check's requests, there was no timeout config for utils.version_check(), which blocks the Interface initiation under certain network environment.

This is a tiny PR that enables timeout for version_check, after which the waiting time would be 3 seconds instead of the default 5 minutes, or even longer.

Closes: #2726

Checklist:

  • I have performed a self-review of my own code
  • I have added a short summary of my change to the CHANGELOG.md
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@abidlabs
Copy link
Copy Markdown
Member

Thank you so much @yujiehecs for the contribution. LGTM!

@abidlabs abidlabs merged commit f9f1f41 into gradio-app:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No timeout for version_check's requests

2 participants